Single dockable in a StackableDockStation

[notzippy]

Hi

When there is only a single Dockable in a StackDockStation (which is on a splitDockStation) the the StackDockStation.getDockParent() returns null, but as soon as more then one Dockable is added then StackDockStation.getDockParent() does not return null. Also the StackDockStation does not show any tabs if there is only one dockable. This behavior is understandable, but is it configurable ? Can you force the StackDockStation to always show tabs ? (Not sure if relevant but I am using the BubbleTheme)

Thanks
nz

Are you certain the StackDockStation is in the tree at all? Having no parent suggest otherwise. And the default behavior of DF is to remove any station that has only one child.

If it is not present you might need to install a "SingleParentRemover" at the DockController (using "setSingleParentRemover"), this SPR should then not remove this special StackDockStation.

As far as I understand my old code (StackDockStation.add and BubbleStackDockComponent), tabs should be visible. I'll have to check again in the evening.

[notzippy]

Calling dockController.setSingleParentRemover(null) allowed me to achieve what I wanted to do - That is to always show the tabs.

Thanks
nz

[ley]

Hi,

I have a StackDockStation with a single dockable and I want to display the single dockable as a tab folder. I used setSingleParentRemover(null); but it's not working.

package bibliothek.notes;
 
import java.awt.BorderLayout;
import java.awt.GridLayout;
 
import javax.swing.JFrame;
import javax.swing.JPanel;
 
import bibliothek.gui.DockFrontend;
import bibliothek.gui.dock.DefaultDockable;
import bibliothek.gui.dock.SplitDockStation;
import bibliothek.gui.dock.StackDockStation;
import bibliothek.gui.dock.station.split.SplitDockProperty;
 
public class Test4 {
 
    public static void main(String[] args) throws Exception {
        JFrame frame = new JFrame();
        JPanel rootPanel = new JPanel();
 
        DockFrontend frontend = new DockFrontend(frame);
        frontend.getController().setSingleParentRemover(null);
        SplitDockStation root = new SplitDockStation();
        frontend.addRoot("root", root);
        
        StackDockStation stack = new StackDockStation();
        stack.setTitleText("Stack");
 
        frontend.getController().setSingleParentRemover(null);
        DefaultDockable a = new DefaultDockable("a");
 
        frontend.addDockable("dockable1", a);
        DefaultDockable b = new DefaultDockable("b");
        frontend.addDockable("dockable2", b);
 
        root.drop(stack, SplitDockProperty.EAST);
        stack.drop(a);
        // stack.drop(b);
        
        rootPanel.setLayout(new GridLayout(1, 1));
        rootPanel.add(root, BorderLayout.CENTER);
 
        frame.add(rootPanel, BorderLayout.CENTER);
        frame.setBounds(20, 20, 500, 500);
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.setVisible(true);
    }
}

Thank you,
ley

Sorry my mistype, setting single parent remover to null ensured that the dockable was not merged into its parents parent station, it did not guarantee that the tab would be visible

nz

[Beni]

Currently single tabs are not implemented. One would need to update the code of StackDockStation to allow that. Sorry, but I'm currently too busy to do that.

Is it possible now with Version 1.0.8 to have a Single dockable in a StackableDockStation?

I tested with preview 5 (not preview 5d since I could not update to preview 5d because of non-matching Glass Extension) and tried the following:
- control.putProperty(SingleTabDecider.SINGLE_TAB_DE CIDER, SingleTabDecider.ALLWAYS);
-

control.putProperty(SingleTabDecider.SINGLE_TAB_DECIDER, new CommonSingleTabDecider(control) {
    /**
 * @new
 */
    @Override
    public boolean showSingleTab (DockStation station, Dockable dockable) {
        if( dockable instanceof CommonDockable ){
            CDockable cdockable = ((CommonDockable) dockable).getDockable();
            return cdockable.isSingleTabShown();
        }

        return false;
    }

});

-

dockable.setTitleShown(true);
dockable.setSingleTabShown(true);

None of these worked. What would be the correct solution?
Or will it be possible in preview 5d?

[Beni]

Yes, Singe-tabs are possible since 1.0.8p1.

You won't see any effect if you use the EclipseTheme, but you will see a change when using any other theme. Calling "setSingleTabShown" is the correct solution. It's working in my applications (1.0.8p5d), you are sure you call the method on the right objects? You don't override the settings later?

(P.S. I'll upload a new glass-extension ASAP, then you can use the newest version).

I now tested with version 1.0.8 preview 5d using

dockable.setSingleTabShown(true);

and

control.setTheme(ThemeMap.KEY_ECLIPSE_THEME); // Want to use Eclipse Theme
control.putProperty(SingleTabDecider.SINGLE_TAB_DECIDER, new CustomCommonSingleTabDecider(control));

and

private static class CustomCommonSingleTabDecider extends CommonSingleTabDecider {

    //---- Constructors

    public CustomCommonSingleTabDecider (CControl control) {
        super(control);
    }

    //---- Methods

    @Override
    public boolean showSingleTab (DockStation station, Dockable dockable) {
        if (dockable.asDockStation() != null) {
            return false;
        }
        if (dockable instanceof CommonDockable) {
            final CDockable cdockable= ((CommonDockable) dockable).getDockable();
            return cdockable.isSingleTabShown();
        }

        return false;
    }

}

What else do I have to do to support Singe-tabs also in Eclipse theme?

When running the demo application in bibliothek.sizeAndColor Singe-tabs are also supported for Eclipse theme.

Thanks in advance

[Beni]

I'm currently without a good idea why it should not work. Could you provide a small example application that reproduces the failure?

I assume you do not play around with a "EclipseThemeConnector"? That would be my only idea how to accidentally "kill" tabs in the EclipseTheme.